Re: [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media

[John Snow]

On 11/28/2017 11:29 AM, Denis V. Lunev wrote:
> On 11/28/2017 07:08 PM, Kevin Wolf wrote:
>> Am 28.11.2017 um 13:10 hat Denis V. Lunev geschrieben:
>>> There are 2 cases I have spotted so far:
>>> 1) IDE ATAPI read processing. Actually this was reported from field
>>> 2) QEMU IO hmp command (found during evaluation of (1))
>>>
>>> SCSI code checks during access that blk_is_available(). These patches add
>>> same checks on different code paths.
>>>
>>> Pls decide whether these patches should go through sub-system trees or via
>>> block tree.
>> Why does this always come up in the last minute? :-(
>>
>> The real fix shouldn't be in the devices, but blk_aio_*() needs to
>> handle empty drives gracefully. We already made a similar fix before the
>> last release in commit 4da97120d, and I already didn't like it back
>> then.
>>
>> Of course, we should have used the time to fix this properly, but as you
>> can see, nothing has happened and we're running out of time again.
>>
>> Kevin
> I see.
> 
> We have started ABRT report collection program a week ago. This
> is the first result for QEMU from the real customer running
> his own workload :(
> 
> What else can I say?
> 
> Den
> 

It's not your fault, it's mine for letting this go for a release. It's
just unfortunate timing. I'm looking at (at least) the IDE portion of
this and the underlying cause in block-backend today.