[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 for-2.12 14/15] s390x/tcg: drop program_inter
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v1 for-2.12 14/15] s390x/tcg: drop program_interrupt() |
Date: |
Wed, 29 Nov 2017 18:18:19 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/28/2017 08:33 PM, David Hildenbrand wrote:
> -void program_interrupt(CPUS390XState *env, uint32_t code, int ilen)
> +void program_interrupt_ra(CPUS390XState *env, uint32_t code, int ilen,
> + uintptr_t ra)
> {
> S390CPU *cpu = s390_env_get_cpu(env);
>
> qemu_log_mask(CPU_LOG_INT, "program interrupt at %#" PRIx64 "\n",
> env->psw.addr);
>
> +#ifdef CONFIG_TCG
> + if (tcg_enabled() && ra) {
> + cpu_restore_state(CPU(cpu), ra);
> + }
> +#endif
Please move this into tcg_s390_program_interrupt by using cpu_loop_exit_restore
there.
r~
- [Qemu-devel] [PATCH v1 for-2.12 08/15] s390x/tcg: io instructions don't need potential_page_fault(), (continued)
- [Qemu-devel] [PATCH v1 for-2.12 08/15] s390x/tcg: io instructions don't need potential_page_fault(), David Hildenbrand, 2017/11/28
- [Qemu-devel] [PATCH v1 for-2.12 10/15] s390x/tcg: use program_interrupt_ra() in DIAG, David Hildenbrand, 2017/11/28
- [Qemu-devel] [PATCH v1 for-2.12 11/15] s390x/tcg: use program_interrupt_ra() in per_check_exception(), David Hildenbrand, 2017/11/28
- [Qemu-devel] [PATCH v1 for-2.12 12/15] s390x/tcg: use program_interrupt_ra() in SACF, David Hildenbrand, 2017/11/28
- [Qemu-devel] [PATCH v1 for-2.12 14/15] s390x/tcg: drop program_interrupt(), David Hildenbrand, 2017/11/28
- [Qemu-devel] [PATCH v1 for-2.12 13/15] s390x/tcg: use program_interrupt_ra() in STSI, David Hildenbrand, 2017/11/28
- [Qemu-devel] [PATCH v1 for-2.12 15/15] s390x/tcg: drop potential_page_fault(), David Hildenbrand, 2017/11/28
- Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.12 00/15] s390x/tcg: cleanup and fix program interrupts, Thomas Huth, 2017/11/29