[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] net: Drop unusual use of do { } while (0);
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] net: Drop unusual use of do { } while (0); |
Date: |
Thu, 30 Nov 2017 17:08:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 30.11.2017 14:41, Eric Blake wrote:
> For a couple of macros in pcnet.c, we have to provide a new scope
> to avoid compiler warnings about declarations in the middle of a
> switch statement that aren't in a sub-scope. But use of
> 'do { ... } while (0);' merely to provide that new scope is arcane
> overkill, compared to just using '{ ... }'.
>
> Signed-off-by: Eric Blake <address@hidden>
> ---
> hw/net/pcnet.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Thomas Huth <address@hidden>