Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter

[Eric Farman]

On 12/01/2017 10:16 AM, Paolo Bonzini wrote:
> On 01/12/2017 16:15, Eric Farman wrote:
> > Commit 5c0919d02066 ("virtio-scsi: Add virtqueue_size parameter allowing
> > virtqueue size to be set.") introduced a new parameter to virtio-scsi.
> > Later, commit 920036106044 ("vhost-user-scsi: add missing virtqueue_size
> > param") added that parameter to the new vhost-user-scsi interface but
> > neglected the existing vhost-scsi interface it was built on.
> >
> > Apply the same change to vhost-scsi, so that we can boot a guest with
> > a device defined.  This also avoids crashing a guest when hotplugging
> > a vhost-scsi device.
> >
> > Signed-off-by: Eric Farman <address@hidden>
> > ---
> >   hw/scsi/vhost-scsi.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
> > index cd4ab05233..9c1bea8ff3 100644
> > --- a/hw/scsi/vhost-scsi.c
> > +++ b/hw/scsi/vhost-scsi.c
> > @@ -233,6 +233,8 @@ static Property vhost_scsi_properties[] = {
> >       DEFINE_PROP_STRING("wwpn", VirtIOSCSICommon, conf.wwpn),
> >       DEFINE_PROP_UINT32("boot_tpgt", VirtIOSCSICommon, conf.boot_tpgt, 0),
> >       DEFINE_PROP_UINT32("num_queues", VirtIOSCSICommon, conf.num_queues, 1),
> > +    DEFINE_PROP_UINT32("virtqueue_size", VirtIOSCSICommon, conf.virtqueue_size,
> > +                       128),
> >       DEFINE_PROP_UINT32("max_sectors", VirtIOSCSICommon, conf.max_sectors,
> >                          0xFFFF),
> >       DEFINE_PROP_UINT32("cmd_per_lun", VirtIOSCSICommon, conf.cmd_per_lun, 
> > 128),
>
> Queued, thanks.
>
> Paolo

Wow, super quick, thank you!  Seeing conversations today, is this queued 
for -rc4, or 2.12 and backport to qemu-stable?

 - Eric