[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.12] scsi-block: Add share-rw option
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH for-2.12] scsi-block: Add share-rw option |
Date: |
Tue, 5 Dec 2017 15:11:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 05/12/2017 08:19, Fam Zheng wrote:
> Scsi-block doesn't use the DEFINE_BLOCK_PROPERTIES() macro so it didn't
> gain the share-rw back when it was added to all other storage devices.
> This option is meaningful here, and need to be used when attaching a
> shared storage to guest.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> hw/scsi/scsi-disk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index 12431177a7..ac65830666 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -3009,6 +3009,7 @@ static const TypeInfo scsi_cd_info = {
> static Property scsi_block_properties[] = {
> DEFINE_BLOCK_ERROR_PROPERTIES(SCSIDiskState, qdev.conf), \
> DEFINE_PROP_DRIVE("drive", SCSIDiskState, qdev.conf.blk),
> + DEFINE_PROP_BOOL("share-rw", SCSIDiskState, qdev.conf.share_rw, false),
> DEFINE_PROP_UINT16("rotation_rate", SCSIDiskState, rotation_rate, 0),
> DEFINE_PROP_END_OF_LIST(),
> };
>
Queued, thanks.
Paolo