Re: [Qemu-devel] [PATCH 2.12] spapr: replace numa_get_node() with lookup in pc-dimm list

[David Gibson]

On Wed, Dec 06, 2017 at 10:57:32AM +0100, Igor Mammedov wrote:
> On Wed, 6 Dec 2017 11:14:06 +1100
> David Gibson <address@hidden> wrote:
> 
> > On Tue, Dec 05, 2017 at 04:41:17PM +0100, Igor Mammedov wrote:
> > > SPAPR is the last user of numa_get_node() and a bunch of
> > > supporting code to maintain numa_info[x].addr list.
> > > 
> > > Get LMB node id from pc-dimm list, which allows to
> > > remove ~80LOC maintaining dynamic address range
> > > lookup list.
> > > 
> > > It also removes pc-dimm dependency on numa_[un]set_mem_node_id()
> > > and makes pc-dimms a sole source of information about which
> > > node it belongs to and removes duplicate data from global
> > > numa_info.
> > > 
> > > Signed-off-by: Igor Mammedov <address@hidden>
> > > ---
> > > Beside making code simpler, my interest in simplification
> > > lies in allowing calling parse_numa_opts() multiple times,
> > > without complex cleanups in case NUMA config is changed
> > > since startup.
> > > 
> > > PS:
> > > build tested only
> > > ---
> > >  include/sysemu/numa.h | 10 ------
> > >  hw/mem/pc-dimm.c      |  2 --
> > >  hw/ppc/spapr.c        | 29 +++++++++++++++-
> > >  numa.c                | 94 
> > > ---------------------------------------------------
> > >  4 files changed, 28 insertions(+), 107 deletions(-)  
> > 
> > Applied to ppc-for-2.12.
> Thanks
> 
> > 
> > It definitely seems like an improvement over what we have.  Looking
> > back at the DIMM list from QMP in the loop seems a little roundabout
> > though.  Maybe we'd be better stepping through the DIMMs, then
> > stepping through the LMBs within each DIMM, rather than just stepping
> > through the LMBs directly.
> Surely that would be better, maybe someone from ppc side would take care
> of it.

Well, it's now on my vast list of things to look at if I ever have
time..

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature