[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Bug 1735384] [RFC PATCH] target/sh4/translate.c: fix T
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [Bug 1735384] [RFC PATCH] target/sh4/translate.c: fix TCG leak during gusa sequence |
Date: |
Wed, 06 Dec 2017 10:52:24 +0000 |
User-agent: |
mu4e 1.0-alpha2; emacs 26.0.90 |
John Paul Adrian Glaubitz <address@hidden> writes:
> Hi Alex!
>
> Wow, thanks! I wanted to run your suggested test today as I ran out of
> time yesterday and now you already fixed it :-).
Can you confirm you've tested it and your happy it works?
>
> Thanks a lot!
>
> Adrian
>
>> On Dec 6, 2017, at 10:30 AM, Alex Bennée <address@hidden> wrote:
>>
>> This fixes bug #1735384 while running java under qemu-sh4. When debug
>> was enabled it showed a problem with TCG temps. Once fixed I was able
>> to run java -version normally.
>>
>> Reported-by: John Paul Adrian Glaubitz <address@hidden>
>> Suggested-by: Richard Henderson <address@hidden>
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>> target/sh4/translate.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/sh4/translate.c b/target/sh4/translate.c
>> index 703020fe87..b4b5c822d0 100644
>> --- a/target/sh4/translate.c
>> +++ b/target/sh4/translate.c
>> @@ -2189,7 +2189,7 @@ static int decode_gusa(DisasContext *ctx, CPUSH4State
>> *env, int *pmax_insns)
>> }
>>
>> /* If op_src is not a valid register, then op_arg was a constant. */
>> - if (op_src < 0) {
>> + if (op_src < 0 && !TCGV_IS_UNUSED(op_arg)) {
>> tcg_temp_free_i32(op_arg);
>> }
>>
>> --
>> 2.15.1
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1735384
>>
>> Title:
>> OpenJDK JVM segfaults on qemu-sh4 (regression)
>>
>> Status in QEMU:
>> New
>>
>> Bug description:
>> Some of the recent changes introduced a regression which makes the
>> OpenJDK JVM crash on qemu-sh4:
>>
>> (sid-sh4-sbuild)address@hidden:/# java -version
>> qemu: uncaught target signal 11 (Segmentation fault) - core dumped
>> Segmentation fault
>> (sid-sh4-sbuild)address@hidden:/#
>>
>> An older version works fine:
>>
>> (sid-sh4-sbuild)address@hidden:/# java -version
>> openjdk version "9.0.1"
>> OpenJDK Runtime Environment (build 9.0.1+11-Debian-1)
>> OpenJDK Zero VM (build 9.0.1+11-Debian-1, interpreted mode)
>> (sid-sh4-sbuild)address@hidden:/#
>>
>> Haven't had time for bisecting this yet.
>>
>> Adrian
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/qemu/+bug/1735384/+subscriptions
--
Alex Bennée