qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2 2/5] net: introduce net_crc32_le() function


From: Mark Cave-Ayland
Subject: Re: [Qemu-devel] [PATCHv2 2/5] net: introduce net_crc32_le() function
Date: Thu, 7 Dec 2017 05:09:09 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 05/12/17 14:31, Eric Blake wrote:

On 12/05/2017 02:17 AM, Mark Cave-Ayland wrote:
This provides a standard ethernet CRC32 little-endian implementation.

Signed-off-by: Mark Cave-Ayland <address@hidden>
---
  include/net/net.h |  2 ++
  net/net.c         | 22 ++++++++++++++++++++++
  2 files changed, 24 insertions(+)

Reviewed-by: Eric Blake <address@hidden>

+            if (carry) {
+                crc = crc ^ POLYNOMIAL_LE;
+            }

Worth writing as 'crc ^= POLYNOMIAL_LE;'?

Yes, works for me.


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]