Re: [Qemu-devel] [PATCH v2] linux-user: Use *at functions instead of caching interp_prefix contents

[Richard Henderson]

On 12/07/2017 09:06 AM, Eric Blake wrote:
>> It's an IF with a /* fallthru */, so there are very few
>> less ugly ways to write it...
> 
> Maybe:
> 
> while (1) {
>     if (interp_dirfd > 0 && filename[0] == '/') {
>         fd = openat(interp_dirfd, filename + 1, O_RDONLY);
>         if (fd >= 0 || errno != ENOENT) {
>             break;
>         }
>     }
>     fd = open(filename, O_RDONLY);
>     break;
> }

Nice.  I'd been pondering

    if (interp_dirfd < 0
        || filename[0] != '/'
        || (fd = openat(interp_dirfd, filename + 1, O_RDONLY),
            fd < 0 && errno == ENOENT)) {
        fd = open(filename, O_RDONLY);
    }


r~