[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/8] vl.c: disallow command line fw cfg without opt/
From: |
minyard |
Subject: |
[Qemu-devel] [PATCH 6/8] vl.c: disallow command line fw cfg without opt/ |
Date: |
Thu, 7 Dec 2017 15:30:11 -0600 |
From: "Michael S. Tsirkin" <address@hidden>
Allowing arbitary file names on command line is setting us up for
failure: future guests will look for a specific QEMU-specified name and
will get confused finding a user file there.
Signed-off-by: Michael S. Tsirkin <address@hidden>
[Change "warning" to "error" in the error report.]
Signed-off-by: Corey Minyard <address@hidden>
---
vl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 1ad1c04..fae9300 100644
--- a/vl.c
+++ b/vl.c
@@ -2400,8 +2400,9 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts,
Error **errp)
return -1;
}
if (strncmp(name, "opt/", 4) != 0) {
- warn_report("externally provided fw_cfg item names "
- "should be prefixed with \"opt/\"");
+ error_report("error: externally provided fw_cfg item names "
+ "should be prefixed with \"opt/\"");
+ return -1;
}
if (nonempty_str(str)) {
size = strlen(str); /* NUL terminator NOT included in fw_cfg blob */
--
2.7.4
- [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes, minyard, 2017/12/07
- [Qemu-devel] [PATCH 5/8] ipmi: disable IRQ and ATN on an external disconnect, minyard, 2017/12/07
- [Qemu-devel] [PATCH 8/8] Add maintainer for the IPMI code, minyard, 2017/12/07
- [Qemu-devel] [PATCH 3/8] ipmi: Add the platform event message command, minyard, 2017/12/07
- [Qemu-devel] [PATCH 6/8] vl.c: disallow command line fw cfg without opt/,
minyard <=
- [Qemu-devel] [PATCH 4/8] ipmi: Fix macro issues, minyard, 2017/12/07
- [Qemu-devel] [PATCH 2/8] ipmi: Don't set the timestamp on add events that don't have it, minyard, 2017/12/07
- [Qemu-devel] [PATCH 1/8] ipmi: Fix SEL get/set time commands, minyard, 2017/12/07
- [Qemu-devel] [PATCH 7/8] ipmi: Allow BMC device properties to be set, minyard, 2017/12/07
- Re: [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes, Corey Minyard, 2017/12/21
- Re: [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes, no-reply, 2017/12/21