[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/12] tests: fix migration-test leak
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 08/12] tests: fix migration-test leak |
Date: |
Fri, 8 Dec 2017 09:57:40 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Marc-André Lureau (address@hidden) wrote:
> Direct leak of 12 byte(s) in 2 object(s) allocated from:
> #0 0x7f50d403c850 in malloc (/lib64/libasan.so.4+0xde850)
> #1 0x7f50d1ddf98f in vasprintf (/lib64/libc.so.6+0x8098f)
>
> Signed-off-by: Marc-André Lureau <address@hidden>
There's an identical patch on list from Juan from a week ago!
Either way,
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> tests/migration-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index be598d3257..799e24ebc6 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -358,13 +358,14 @@ static void migrate_check_parameter(QTestState *who,
> const char *parameter,
> const char *value)
> {
> QDict *rsp, *rsp_return;
> - const char *result;
> + char *result;
>
> rsp = wait_command(who, "{ 'execute': 'query-migrate-parameters' }");
> rsp_return = qdict_get_qdict(rsp, "return");
> result = g_strdup_printf("%" PRId64,
> qdict_get_try_int(rsp_return, parameter, -1));
> g_assert_cmpstr(result, ==, value);
> + g_free(result);
> QDECREF(rsp);
> }
>
> --
> 2.15.1.355.g36791d7216
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH 02/12] build-sys: silence make by default, (continued)
- [Qemu-devel] [PATCH 03/12] build-sys: add a rule to print a variable, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 04/12] build-sys: add AddressSanitizer when --enable-debug if possible, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 05/12] tests: fix check-qobject leak:, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 07/12] readline: add a free function, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 06/12] vl: fix direct firmware directories leak, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 08/12] tests: fix migration-test leak, Marc-André Lureau, 2017/12/07
- Re: [Qemu-devel] [PATCH 08/12] tests: fix migration-test leak,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 09/12] crypto: fix stack-buffer-overflow error, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 11/12] tests: fix qmp-test leak, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 10/12] qemu-config: fix leak in query-command-line-options, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 12/12] WIP ucontext: annotate coroutine stack for ASAN, Marc-André Lureau, 2017/12/07
- Re: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes, no-reply, 2017/12/11
- Re: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes, no-reply, 2017/12/11