[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 4/8] vhost: New memory update functions
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PATCH v3 4/8] vhost: New memory update functions |
Date: |
Mon, 11 Dec 2017 19:46:06 +0000 |
From: "Dr. David Alan Gilbert" <address@hidden>
vhost_update_mem will replace the existing update mechanism.
They make use of the Flatview we have now to make the update simpler.
This commit just adds the basic structure.
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
hw/virtio/vhost.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 50 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index c7ce7baf9b..6d720036db 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -634,11 +634,51 @@ static void vhost_begin(MemoryListener *listener)
dev->mem_changed_start_addr = -1;
}
+struct vhost_update_mem_tmp {
+ struct vhost_dev *dev;
+ uint32_t nregions;
+ struct vhost_memory_region *regions;
+};
+
+/* Called for each MRS from vhost_update_mem */
+static int vhost_update_mem_cb(MemoryRegionSection *mrs, void *opaque)
+{
+ if (!vhost_section(mrs)) {
+ return 0;
+ }
+
+ /* TODO */
+ return 0;
+}
+
+static int vhost_update_mem(struct vhost_dev *dev, bool *changed)
+{
+ int res;
+ struct vhost_update_mem_tmp vtmp;
+ vtmp.regions = 0;
+ vtmp.nregions = 0;
+ vtmp.dev = dev;
+
+ *changed = false;
+ res = address_space_iterate(&address_space_memory,
+ vhost_update_mem_cb, &vtmp);
+ if (res) {
+ goto out;
+ }
+
+ /* TODO */
+ *changed = dev->mem_changed_start_addr < dev->mem_changed_end_addr;
+out:
+ g_free(vtmp.regions);
+ return res;
+}
+
static void vhost_commit(MemoryListener *listener)
{
struct vhost_dev *dev = container_of(listener, struct vhost_dev,
memory_listener);
uint64_t log_size;
+ bool changed;
int r;
if (!dev->memory_changed) {
@@ -647,7 +687,12 @@ static void vhost_commit(MemoryListener *listener)
if (!dev->started) {
return;
}
- if (dev->mem_changed_start_addr > dev->mem_changed_end_addr) {
+ if (vhost_update_mem(dev, &changed)) {
+ return;
+ }
+
+ if (!changed) {
+ /* None of the mappings we care about changed */
return;
}
@@ -1523,6 +1568,7 @@ void vhost_ack_features(struct vhost_dev *hdev, const int
*feature_bits,
int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev)
{
int i, r;
+ bool changed;
/* should only be called after backend is connected */
assert(hdev->vhost_ops);
@@ -1535,6 +1581,9 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice
*vdev)
goto fail_features;
}
+ if (vhost_update_mem(hdev, &changed)) {
+ goto fail_mem;
+ }
if (vhost_dev_has_iommu(hdev)) {
memory_listener_register(&hdev->iommu_listener, vdev->dma_as);
}
--
2.14.3
- [Qemu-devel] [PATCH v3 0/8] Rework vhost memory region updates, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 1/8] memory: address_space_iterate, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 2/8] vhost: Move log_dirty check, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 3/8] vhost: Simplify ring verification checks, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 4/8] vhost: New memory update functions,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PATCH v3 5/8] vhost: update_mem_cb implementation, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 7/8] vhost: Remove old vhost_set_memory etc, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 6/8] vhost: Compare and copy updated region data into device state, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 8/8] vhost: Move mem_sections maintenance into commit/update routines, Dr. David Alan Gilbert (git), 2017/12/11