[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/26] sdbus: add a QMP command to access a SDBu
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 01/26] sdbus: add a QMP command to access a SDBus |
|
Date: |
Thu, 14 Dec 2017 10:06:58 +0100 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 14.12.2017 um 00:20 hat Philippe Mathieu-Daudé geschrieben:
> Use Base64 to serialize the binary blobs in JSON.
> So far at most 512 bytes will be transfered, which result
> in a 684 bytes payload.
> Since this command is intented for qtesting, this is acceptable.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Doing this kind of thing over QMP doesn't look right to me. qtests
should access hardware the same way as real guests access the hardware
(i.e. MMIO and I/O ports).
But if for some reason the QMP maintainers were to think that this is
acceptable in QMP, I'd argue it should at least get an x-debug- prefix
to avoid making it a stable API that management tools may rely on.
Kevin
[Qemu-devel] [RFC PATCH 02/26] sdcard: add a Python qtest, Philippe Mathieu-Daudé, 2017/12/13
[Qemu-devel] [PATCH 03/26] sdcard: use ldst API, Philippe Mathieu-Daudé, 2017/12/13
[Qemu-devel] [PATCH 04/26] sdcard: replace fprintf() -> qemu_log_mask(), Philippe Mathieu-Daudé, 2017/12/13
[Qemu-devel] [PATCH 05/26] sdcard: rename sd_set_mode() -> sd_update_mode(), Philippe Mathieu-Daudé, 2017/12/13