Re: [Qemu-devel] [RFC v5 17/26] qmp: add new event "request-dropped"

[Stefan Hajnoczi]

On Tue, Dec 05, 2017 at 01:51:51PM +0800, Peter Xu wrote:
> +##
> +# @RequestDropReason:
> +#
> +# Reasons that caused one command to be dropped.
> +#
> +# @queue-full: the queue of request is full.
> +#
> +# Since: 2.12
> +##
> +{ 'enum': 'RequestDropReason',

qapi-schema.json calls them "commands", not "requests".  Please rename
it CommandDropReason for consistency and update the documentation.

> +  'data': [ 'queue-full' ] }
> +
> +##
> +# @REQUEST_DROPPED:
> +#
> +# Emitted when one QMP request is dropped due to some reason.
> +# REQUEST_DROPPED is only emitted when the oob capability is enabled.

Please make it clear that requests can only be dropped when the oob
capability is enabled.

  Emitted when a command is dropped due to some reason.  Commands can
  only be dropped when the oob capability is enabled.

signature.asc
Description: PGP signature