[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/pnv: change powernv_ prefix to p
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/pnv: change powernv_ prefix to pnv_ for overall naming consistency |
Date: |
Fri, 15 Dec 2017 08:16:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 12/15/2017 07:43 AM, Alexey Kardashevskiy wrote:
> On 15/12/17 17:17, Cédric Le Goater wrote:
>> Signed-off-by: Cédric Le Goater <address@hidden>
>> ---
>> hw/ppc/pnv.c | 84
>> ++++++++++++++++++++++++++--------------------------
>> hw/ppc/pnv_core.c | 8 ++---
>> hw/ppc/pnv_lpc.c | 2 +-
>> include/hw/ppc/pnv.h | 8 ++---
>> 4 files changed, 51 insertions(+), 51 deletions(-)
>>
>> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
>> index c35c439d816b..4bc5f61d0da7 100644
>> --- a/hw/ppc/pnv.c
>> +++ b/hw/ppc/pnv.c
>> @@ -77,7 +77,7 @@ static const char *pnv_chip_core_typename(const PnvChip *o)
>> * that has a different "affinity". In practice, it means one range
>> * per chip.
>> */
>> -static void powernv_populate_memory_node(void *fdt, int chip_id, hwaddr
>> start,
>> +static void pnv_populate_memory_node(void *fdt, int chip_id, hwaddr start,
>> hwaddr size)
>
> You may also want to fix indentations like the line above.
yes. I missed that. I should run indent after using sed.
While I am at it, I can also change the name of the routines
populating the device tree.
David,
are you following more or less this pattern :
<machine>_dt_<device>
Thanks,
C.