[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 5/7] vhost-user: VHOST_USER_
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 5/7] vhost-user: VHOST_USER_SET_VHOST_PCI msg |
Date: |
Fri, 15 Dec 2017 12:40:02 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Wed, Dec 06, 2017 at 06:32:50PM +0800, Wei Wang wrote:
> On 12/06/2017 12:00 AM, Stefan Hajnoczi wrote:
> > On Tue, Dec 05, 2017 at 11:33:14AM +0800, Wei Wang wrote:
> > > Add a new vhost-uer protocol msg, VHOST_USER_SET_VHOST_PCI. This msg is
> > > used to signal the vhost-pci device to start/stop working.
> > >
> > > Signed-off-by: Wei Wang <address@hidden>
> > > ---
> > > hw/net/vhost_net.c | 37
> > > +++++++++++++++++++++++++++++++++++++
> > > hw/virtio/vhost-pci-slave.c | 2 +-
> > > hw/virtio/vhost-user.c | 17 +++++++++++++++++
> > > hw/virtio/vhost.c | 7 +++++++
> > > include/hw/virtio/vhost-backend.h | 2 ++
> > > include/hw/virtio/vhost-user.h | 2 ++
> > > include/hw/virtio/vhost.h | 2 ++
> > > include/net/vhost_net.h | 2 ++
> > > 8 files changed, 70 insertions(+), 1 deletion(-)
> > New protocol messages must be documented in docs/interop/vhost-user.txt.
>
> OK, I'll add it to the doc after the discussion.
>
> >
> > Why is a new message needed? I'm not sure why it is specific to
> > vhost-pci.
>
> Yes, it might be useful for other vhost-user slave implementations. Probably
> we can name it "VHOST_USER_SET_SLAVE"?
> The message is used to "link up" or "link down" the slave device. For
> example, when virtio-net leaves, it sends a "VHOST_USER_SET_SLAVE" msg to
> the salve to link down the slave device.
> (a similar msg is VHOST_USER_SET_VRING_ENABLE, but that is for virtqueue
> enable/disable, not for a device level enable/disable)
Why is VHOST_USER_SET_VHOST_PCI necessary when DPDK and other vhost-user
net device slaves already exist today and didn't need it?
Stefan
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [virtio-dev] [PATCH v3 2/7] vhost-pci-net: add vhost-pci-net, (continued)
[Qemu-devel] [PATCH v3 3/7] virtio/virtio-pci.c: add vhost-pci-net-pci, Wei Wang, 2017/12/04
[Qemu-devel] [PATCH v3 4/7] vhost-pci-slave: add vhost-pci slave implementation, Wei Wang, 2017/12/04
[Qemu-devel] [PATCH v3 5/7] vhost-user: VHOST_USER_SET_VHOST_PCI msg, Wei Wang, 2017/12/04
[Qemu-devel] [PATCH v3 6/7] vhost-pci-slave: handle VHOST_USER_SET_VHOST_PCI, Wei Wang, 2017/12/04
[Qemu-devel] [PATCH v3 7/7] virtio/vhost.c: vhost-pci needs remote gpa, Wei Wang, 2017/12/04
Re: [Qemu-devel] [PATCH v3 0/7] Vhost-pci for inter-VM communication, no-reply, 2017/12/04
Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication, Jason Wang, 2017/12/05