[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/15] mc146818rtc: always register rtc to rtc list
From: |
Hervé Poussineau |
Subject: |
[Qemu-devel] [PATCH 04/15] mc146818rtc: always register rtc to rtc list |
Date: |
Sat, 16 Dec 2017 10:02:17 +0100 |
We are not required anymore to use rtc_init() function.
Signed-off-by: Hervé Poussineau <address@hidden>
---
hw/timer/mc146818rtc.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
index 73d1ce21de..1b6847b803 100644
--- a/hw/timer/mc146818rtc.c
+++ b/hw/timer/mc146818rtc.c
@@ -905,6 +905,13 @@ static void rtc_get_date(Object *obj, struct tm
*current_tm, Error **errp)
rtc_get_time(s, current_tm);
}
+static int rtc_initfn(DeviceState *dev)
+{
+ RTCState *s = MC146818_RTC(dev);
+ QLIST_INSERT_HEAD(&rtc_devices, s, link);
+ return 0;
+}
+
static void rtc_realizefn(DeviceState *dev, Error **errp)
{
ISADevice *isadev = ISA_DEVICE(dev);
@@ -973,11 +980,9 @@ ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq
intercept_irq)
{
DeviceState *dev;
ISADevice *isadev;
- RTCState *s;
isadev = isa_create(bus, TYPE_MC146818_RTC);
dev = DEVICE(isadev);
- s = MC146818_RTC(isadev);
qdev_prop_set_int32(dev, "base_year", base_year);
qdev_init_nofail(dev);
if (intercept_irq) {
@@ -985,7 +990,6 @@ ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq
intercept_irq)
} else {
isa_connect_gpio_out(isadev, 0, RTC_ISA_IRQ);
}
- QLIST_INSERT_HEAD(&rtc_devices, s, link);
return isadev;
}
@@ -1012,12 +1016,11 @@ static void rtc_class_initfn(ObjectClass *klass, void
*data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
+ dc->init = rtc_initfn;
dc->realize = rtc_realizefn;
dc->reset = rtc_resetdev;
dc->vmsd = &vmstate_rtc;
dc->props = mc146818rtc_properties;
- /* Reason: needs to be wired up by rtc_init() */
- dc->user_creatable = false;
}
static void rtc_finalize(Object *obj)
--
2.11.0
- [Qemu-devel] [PATCH 03/15] mc146818rtc: move structure to header file, (continued)
- [Qemu-devel] [PATCH 03/15] mc146818rtc: move structure to header file, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH 01/15] fdc: move object structures to header file, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH 13/15] piix4: add a speaker as specified in datasheet, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH 11/15] piix4: add a floppy controller, 1 parallel port and 2 serial ports, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH 07/15] piix4: add a i8259 interrupt controller as specified in datasheet, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH 06/15] piix4: add Reset Control Register, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH 15/15] piix4: we can now instanciate a PIIX4 with -device, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH 12/15] piix4: add a mc146818rtc controller as specified in datasheet, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH 09/15] piix4: add a i8254 pit controller as specified in datasheet, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH 14/15] piix4: rename PIIX4 object to piix4-isa, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH 04/15] mc146818rtc: always register rtc to rtc list,
Hervé Poussineau <=
- [Qemu-devel] [PATCH 05/15] piix4: rename some variables in realize function, Hervé Poussineau, 2017/12/16
- Re: [Qemu-devel] [PATCH 00/15] piix4: cleanup and improvements, no-reply, 2017/12/17
- [Qemu-devel] [PATCH 00/15] piix4: cleanup and improvements, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH v2 01/15] fdc: move object structures to header file, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH v2 02/15] serial/parallel: move object structures to header file, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH v2 03/15] mc146818rtc: move structure to header file, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH v2 05/15] piix4: rename some variables in realize function, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH v2 04/15] mc146818rtc: always register rtc to rtc list, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH v2 06/15] piix4: add Reset Control Register, Hervé Poussineau, 2017/12/16
- [Qemu-devel] [PATCH v2 07/15] piix4: add a i8259 interrupt controller as specified in datasheet, Hervé Poussineau, 2017/12/16