[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v5 26/26] tests: qmp-test: add oob test
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [RFC v5 26/26] tests: qmp-test: add oob test |
Date: |
Mon, 18 Dec 2017 17:51:45 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, Dec 14, 2017 at 02:47:12PM +0000, Stefan Hajnoczi wrote:
> On Tue, Dec 05, 2017 at 01:52:00PM +0800, Peter Xu wrote:
> > + /* Try a fake capability, it should fail. */
> > + resp = qmp("{ 'execute': 'qmp_capabilities', "
> > + " 'arguments': { 'enable': [ 'cap-does-not-exist' ] } }");
> > + g_assert(qdict_haskey(resp, "error"));
>
> Missing QDECREF(resp) here and throughout the rest of the function.
I believe I missed four QDECREF()s.
>
> Besides that:
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
Hope my counting is correct, then I'll add the r-b. Thanks!
--
Peter Xu
- [Qemu-devel] [RFC v5 24/26] docs: update QMP documents for OOB commands, (continued)
[Qemu-devel] [RFC v5 25/26] tests: qmp-test: verify command batching, Peter Xu, 2017/12/05
[Qemu-devel] [RFC v5 26/26] tests: qmp-test: add oob test, Peter Xu, 2017/12/05
Re: [Qemu-devel] [RFC v5 00/26] QMP: out-of-band (OOB) execution support, Stefan Hajnoczi, 2017/12/14
Re: [Qemu-devel] [RFC v5 00/26] QMP: out-of-band (OOB) execution support, Fam Zheng, 2017/12/15