[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/7] blockjob: record time of last yield
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/7] blockjob: record time of last yield |
Date: |
Mon, 18 Dec 2017 14:22:22 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, Dec 14, 2017 at 10:55:22AM -0500, John Snow wrote:
>
>
> On 12/14/2017 03:38 AM, Paolo Bonzini wrote:
> > On 14/12/2017 01:59, John Snow wrote:
> >> qemu_coroutine_yield();
> >> + job->last_yield_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
> >
> > This is not the time the job has yielded control, but the time the job
> > has gotten it back. Is it intended?
> >
> > Thanks,
> >
> > Paolo
> >
>
> Yes, since that matches how mirror recorded last_sleep_ns, except for
> where it records the 0ns sleep, then it records it beforehand (close
> enough.)
>
> I intended for this valuable to count how long we haven't yielded,
> basically. Thought being that any time we are yielded, we're being
> cooperative.
>
> This is the selfishness counter :)
Maybe last_enter_ns is a clearer name.
signature.asc
Description: PGP signature