[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tpm: move qdev_prop_tpm to hw/tpm/
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH] tpm: move qdev_prop_tpm to hw/tpm/ |
Date: |
Mon, 18 Dec 2017 17:06:18 +0100 |
On Mon, 18 Dec 2017 11:00:59 -0500 (EST)
Paolo Bonzini <address@hidden> wrote:
> > > ../hw/tpm/tpm_tis.o:tpm_tis.c:(.data+0x50): undefined reference to
> > > `qdev_prop_tpm'
> > > collect2: error: ld returned 1 exit status
> > > Makefile:193: recipe for target 'qemu-system-x86_64w.exe' failed
> > > make[1]: *** [qemu-system-x86_64w.exe] Error 1
> > > make: *** [subdir-x86_64-softmmu] Error 2
> > > Makefile:384: recipe for target 'subdir-x86_64-softmmu' failed
> >
> > Seems we need to build tpm_util also when tpm_tis is built (and none of
> > the others).
>
> Or place the property in its own file.
Currently testing building tpm_util all of the time; waiting for a vote
from the tpm maintainer.
[Building a file called 'util' all of the time makes sense to me.]