|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH v1 04/19] include/fpu/softfloat: implement float16_set_sign helper |
Date: | Mon, 18 Dec 2017 13:44:36 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 12/11/2017 04:56 AM, Alex Bennée wrote: > +static inline float16 float16_set_sign(float16 a, int sign) > +{ > + return make_float16((float16_val(a) & 0x7fff) | (sign << 15)); > +} > + 1) Do we use this anywhere? 2) While this is probably in line with the other implementations, but going to a more qemu-ish style this should use deposit32. Anyway, Reviewed-by: Richard Henderson <address@hidden> r~
[Prev in Thread] | Current Thread | [Next in Thread] |