[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scripts/make-release: More .git removal
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] scripts/make-release: More .git removal |
Date: |
Tue, 19 Dec 2017 10:59:49 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, Dec 18, 2017 at 05:33:54PM -0500, Cole Robinson wrote:
> As was last done in 379e21c25, we want to remove .git files for
> submodules here, which we aren't presently doing for capstone and
> keycodemapdb.
>
> Rather than a whitelist use 'find' to future proof this
>
> Signed-off-by: Cole Robinson <address@hidden>
> ---
> scripts/make-release | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrange <address@hidden>
>
> diff --git a/scripts/make-release b/scripts/make-release
> index 3917df7142..7c7bec577f 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -19,7 +19,7 @@ pushd ${destination}
> git checkout "v${version}"
> git submodule update --init
> (cd roms/seabios && git describe --tags --long --dirty > .version)
> -rm -rf .git roms/*/.git dtc/.git pixman/.git
> +find . -depth -name .git -exec rm -rf '{}' \;
> # FIXME: The following line is a workaround for avoiding filename collisions
> # when unpacking u-boot sources on case-insensitive filesystems. Once we
> # update to something with u-boot commit 610eec7f0 we can drop this line.
> --
> 2.14.3
>
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|