[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v6 06/27] monitor: move the cur_mon hack deeper fo
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC v6 06/27] monitor: move the cur_mon hack deeper for QMP |
Date: |
Wed, 20 Dec 2017 16:42:21 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Tue, Dec 19, 2017 at 04:45:36PM +0800, Peter Xu wrote:
> In monitor_qmp_read(), we have the hack to temporarily replace the
> cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher
> routine since the Monitor pointer can be actually obtained using
> container_of() upon the parser object, just like most of the other JSON
> parser users do.
>
> This does not make much sense as a single patch. However, this will be
> a big step for the next patch, when the QMP dispatcher routine will be
> split from the QMP parser.
>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> monitor.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [RFC v6 00/27] QMP: out-of-band (OOB) execution support, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 01/27] chardev: use backend chr context when watch for fe, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 02/27] qobject: introduce qstring_get_try_str(), Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 03/27] qobject: introduce qobject_get_try_str(), Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 04/27] qobject: let object_property_get_str() use new API, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 05/27] monitor: move skip_flush into monitor_data_init, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 06/27] monitor: move the cur_mon hack deeper for QMP, Peter Xu, 2017/12/19
- Re: [Qemu-devel] [RFC v6 06/27] monitor: move the cur_mon hack deeper for QMP,
Stefan Hajnoczi <=
- [Qemu-devel] [RFC v6 07/27] monitor: unify global init, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 08/27] monitor: let mon_list be tail queue, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 09/27] monitor: create monitor dedicate iothread, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 10/27] monitor: allow to use IO thread for parsing, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 11/27] qmp: introduce QMPCapability, Peter Xu, 2017/12/19