[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/5] vhost-user-test: fix features mask
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/5] vhost-user-test: fix features mask |
Date: |
Fri, 22 Dec 2017 14:41:33 +0100 |
On Thu, Dec 21, 2017 at 10:21 PM, Maxime Coquelin
<address@hidden> wrote:
> VIRTIO_NET_F_MAC is a bit position, not a bit mask.
>
> Signed-off-by: Maxime Coquelin <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> tests/vhost-user-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> index e2c89ed376..43c6528644 100644
> --- a/tests/vhost-user-test.c
> +++ b/tests/vhost-user-test.c
> @@ -177,7 +177,7 @@ static void init_virtio_dev(TestServer *s)
> qvirtio_set_driver(&dev->vdev);
>
> features = qvirtio_get_features(&dev->vdev);
> - features = features & VIRTIO_NET_F_MAC;
> + features = features & (1u << VIRTIO_NET_F_MAC);
> qvirtio_set_features(&dev->vdev, features);
>
> qvirtio_set_driver_ok(&dev->vdev);
> --
> 2.14.3
>
>
--
Marc-André Lureau
- [Qemu-devel] [PATCH v3 0/5] vhost-user-test: Fixes & code clean-up, Maxime Coquelin, 2017/12/21
- [Qemu-devel] [PATCH v3 2/5] vhost-user-test: extract read-guest-mem test from main loop, Maxime Coquelin, 2017/12/21
- [Qemu-devel] [PATCH v3 1/5] vhost-user-test: fix features mask, Maxime Coquelin, 2017/12/21
- Re: [Qemu-devel] [PATCH v3 1/5] vhost-user-test: fix features mask,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v3 3/5] vhost-user-test: setup virtqueues in all tests, Maxime Coquelin, 2017/12/21
- [Qemu-devel] [PATCH v3 4/5] vhost-user-test: make features mask an init_virtio_dev() argument, Maxime Coquelin, 2017/12/21
- [Qemu-devel] [PATCH v3 5/5] vhost-user-test: use init_virtio_dev in multiqueue test, Maxime Coquelin, 2017/12/21
- Re: [Qemu-devel] [PATCH v3 0/5] vhost-user-test: Fixes & code clean-up, Michael S. Tsirkin, 2017/12/21
- Re: [Qemu-devel] [PATCH v3 0/5] vhost-user-test: Fixes & code clean-up, no-reply, 2017/12/22