Re: [Qemu-devel] [PATCH v2 1/2] qmp: adding 'wakeup-suspend-support' in query-target

[Eric Blake]

On 01/02/2018 02:28 PM, Daniel Henrique Barboza wrote:

>>> With this extra tool, management can avoid situations where a guest
>>> that does not have proper suspend/wake capabilities ends up in
>>> inconsistent state (e.g.
>>> https://github.com/open-power-host-os/qemu/issues/31).
>>>
>>> Signed-off-by: Daniel Henrique Barboza <address@hidden>
>>> ---
>> Only an interface review:
>>

>>> @@ -2388,11 +2388,12 @@
>>>   # Information describing the QEMU target.
>>>   #
>>>   # @arch: the target architecture (eg "x86_64", "i386", etc)
>>> +# @wakeup-suspend-support: true if the target supports wake up from
>>> suspend
>> Missing a '(since 2.12)' notation.
> 
> TargetInfo is marked as "Since 1.2.0".  Should I add the 2.12.0 notation
> to the
> new parameter or change the 1.2.0 notation of TargetInfo?

Just on the new field, as in:

##
# @TargetInfo:
#
# Information describing the QEMU target.
#
# @arch: the target architecture (eg "x86_64", "i386", etc)
# @wakeup-suspend-support: true if the target supports wake up from
#                          suspend (since 2.12)
#
# Since: 1.2.0
##

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature