[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/42] sdhci: refactor common sysbus/pci clas
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/42] sdhci: refactor common sysbus/pci class_init() into sdhci_class_init() |
Date: |
Wed, 3 Jan 2018 15:49:15 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, 12/29 14:48, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/sd/sdhci.c | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> index a11469fbca..38d82b4c61 100644
> --- a/hw/sd/sdhci.c
> +++ b/hw/sd/sdhci.c
> @@ -1275,6 +1275,16 @@ static Property sdhci_properties[] = {
> DEFINE_PROP_END_OF_LIST(),
> };
>
> +static void sdhci_class_init(ObjectClass *klass, void *data)
> +{
> + DeviceClass *dc = DEVICE_CLASS(klass);
> +
> + set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
> + dc->vmsd = &sdhci_vmstate;
> + dc->props = sdhci_properties;
> + dc->reset = sdhci_poweron_reset;
> +}
> +
> /* --- qdev PCI --- */
>
> static void sdhci_pci_realize(PCIDevice *dev, Error **errp)
> @@ -1299,7 +1309,6 @@ static void sdhci_pci_exit(PCIDevice *dev)
>
> static void sdhci_pci_class_init(ObjectClass *klass, void *data)
> {
> - DeviceClass *dc = DEVICE_CLASS(klass);
> PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
>
> k->realize = sdhci_pci_realize;
> @@ -1307,10 +1316,8 @@ static void sdhci_pci_class_init(ObjectClass *klass,
> void *data)
> k->vendor_id = PCI_VENDOR_ID_REDHAT;
> k->device_id = PCI_DEVICE_ID_REDHAT_SDHCI;
> k->class_id = PCI_CLASS_SYSTEM_SDHCI;
> - set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
> - dc->vmsd = &sdhci_vmstate;
> - dc->props = sdhci_properties;
> - dc->reset = sdhci_poweron_reset;
> +
> + sdhci_class_init(klass, data);
> }
>
> static const TypeInfo sdhci_pci_info = {
> @@ -1356,10 +1363,9 @@ static void sdhci_sysbus_class_init(ObjectClass
> *klass, void *data)
> {
> DeviceClass *dc = DEVICE_CLASS(klass);
>
> - dc->vmsd = &sdhci_vmstate;
> - dc->props = sdhci_properties;
> dc->realize = sdhci_sysbus_realize;
> - dc->reset = sdhci_poweron_reset;
> +
> + sdhci_class_init(klass, data);
Previously we don't do
set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
in this function. Again if this is intended it should be mentioned in the commit
message?
Fam
> }
>
> static const TypeInfo sdhci_sysbus_info = {
> --
> 2.15.1
>
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 05/42] sdhci: refactor common sysbus/pci class_init() into sdhci_class_init(),
Fam Zheng <=