[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] scsi-disk: release AioContext in unaligned WRITE SA
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH] scsi-disk: release AioContext in unaligned WRITE SAME case |
Date: |
Thu, 4 Jan 2018 14:25:02 +0000 |
scsi_write_same_complete() can retry the write if the request was
unaligned. Make sure to release the AioContext when that code path is
taken!
This patch fixes a hang when QEMU terminates after an unaligned WRITE
SAME request has been processed with dataplane. The hang occurs because
iothread_stop_all() cannot acquire the AioContext lock that was leaked
by the IOThread in scsi_write_same_complete().
Fixes: b9e413dd37
("block: explicitly acquire aiocontext in aio callbacks that need it").
Cc: Paolo Bonzini <address@hidden>
Reported-by: Cong Li <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/scsi/scsi-disk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index e58833a087..49d2559d93 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -1755,6 +1755,7 @@ static void scsi_write_same_complete(void *opaque, int
ret)
data->sector << BDRV_SECTOR_BITS,
&data->qiov, 0,
scsi_write_same_complete, data);
+ aio_context_release(blk_get_aio_context(s->qdev.conf.blk));
return;
}
--
2.14.3
- [Qemu-devel] [PATCH] scsi-disk: release AioContext in unaligned WRITE SAME case,
Stefan Hajnoczi <=