Re: [Qemu-devel] [PATCH 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f6555aed49 QEMU CAN bus emulation documentation
b43b31c8f5 CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added.
49228bb881 CAN bus PCM-3680I PCI (dual SJA1000 channel) emulation added.
94bf8a7051 CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.
137eb4460e CAN bus SJA1000 chip register level emulation for QEMU
7b408f317f CAN bus support to connect bust to Linux host SocketCAN interface.
a56657c636 CAN bus simple messages transport implementation for QEMU

=== OUTPUT BEGIN ===
Checking PATCH 1/7: CAN bus simple messages transport implementation for QEMU...
WARNING: line over 80 characters
#199: FILE: hw/can/can_core.c:125:
+        error_report("CAN bus connect to host device not supported on this 
system");

WARNING: line over 80 characters
#329: FILE: include/can/can_emu.h:78:
+#define QEMU_CAN_INV_FILTER 0x20000000U /* to be set in qemu_can_filter.can_id 
*/

WARNING: line over 80 characters
#365: FILE: include/can/can_emu.h:114:
+extern int (*can_bus_connect_to_host_variant)(CanBusState *bus, const char 
*name);

total: 0 errors, 3 warnings, 328 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/7: CAN bus support to connect bust to Linux host SocketCAN 
interface....
WARNING: line over 80 characters
#228: FILE: hw/can/can_socketcan.c:194:
+CanBusSocketcanConnectState *can_bus_socketcan_connect_new(const char 
*host_dev_name)

WARNING: line over 80 characters
#298: FILE: hw/can/can_socketcan.c:264:
+int can_bus_connect_to_host_socketcan(CanBusState *bus, const char 
*host_dev_name)

total: 0 errors, 2 warnings, 303 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/7: CAN bus SJA1000 chip register level emulation for QEMU...
WARNING: line over 80 characters
#383: FILE: hw/can/can_sja1000.c:337:
+        buff[2] = extract32(frame->can_id, 0, 3) << 5; /* 
ID.02~ID.00,x,x,x,x,x */

WARNING: line over 80 characters
#398: FILE: hw/can/can_sja1000.c:352:
+    if ((frame->can_id & QEMU_CAN_EFF_FLAG) || /* EFF, not support for 
BasicMode. */

WARNING: line over 80 characters
#399: FILE: hw/can/can_sja1000.c:353:
+       (frame->can_id & QEMU_CAN_ERR_FLAG)) {  /* or Error frame, NOT support 
now. */

WARNING: line over 80 characters
#486: FILE: hw/can/can_sja1000.c:440:
+                s->status_pel |= (3 << 2); /* Set transmission complete 
status, */

WARNING: line over 80 characters
#595: FILE: hw/can/can_sja1000.c:549:
+                s->status_bas |= (3 << 2); /* Set transmission complete 
status, */

WARNING: line over 80 characters
#615: FILE: hw/can/can_sja1000.c:569:
+                        fprintf(stderr, " %02X", s->rx_buff[(s->rxbuf_start + 
i) %

WARNING: line over 80 characters
#847: FILE: hw/can/can_sja1000.c:801:
+        s->status_pel |= (1 << 4); /* the CAN controller is receiving a 
message */

WARNING: line over 80 characters
#897: FILE: hw/can/can_sja1000.c:851:
+        s->status_bas |= (1 << 4); /* the CAN controller is receiving a 
message */

ERROR: do not use C99 // comments
#1087: FILE: hw/can/can_sja1000.h:39:
+//#define DEBUG_CAN

WARNING: line over 80 characters
#1108: FILE: hw/can/can_sja1000.h:60:
+    uint8_t         interrupt_en;  /* PeliCAN, addr 4, Interrupt Enable 
register */

WARNING: line over 80 characters
#1109: FILE: hw/can/can_sja1000.h:61:
+    uint8_t         rxmsg_cnt;     /* PeliCAN, addr 29, RX message counter. 
DS-p49 */

WARNING: line over 80 characters
#1110: FILE: hw/can/can_sja1000.h:62:
+    uint8_t         rxbuf_start;   /* PeliCAN, addr 30, RX buffer start 
address, DS-p49 */

WARNING: line over 80 characters
#1111: FILE: hw/can/can_sja1000.h:63:
+    uint8_t         clock;         /* PeliCAN, addr 31, Clock Divider 
register, DS-p55 */

WARNING: line over 80 characters
#1125: FILE: hw/can/can_sja1000.h:77:
+    uint8_t         code;          /* BasicCAN, addr 4, Acceptance code 
register */

WARNING: line over 80 characters
#1126: FILE: hw/can/can_sja1000.h:78:
+    uint8_t         mask;          /* BasicCAN, addr 5, Acceptance mask 
register */

WARNING: line over 80 characters
#1171: FILE: hw/can/can_sja1000.h:123:
+/* ID bytes (11 bits in 0 and 1 or 16 bits in 0,1 and 13 bits in 2,3 
(extended)) */

total: 1 errors, 15 warnings, 1184 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/7: CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation 
added....
Checking PATCH 5/7: CAN bus PCM-3680I PCI (dual SJA1000 channel) emulation 
added....
WARNING: line over 80 characters
#70: FILE: hw/can/can_pcm3680_pci.c:46:
+#define PCM3680i_PCI_VENDOR_ID1     0x13fe    /* the PCI device and vendor IDs 
*/

total: 0 errors, 1 warnings, 340 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/7: CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation 
added....
WARNING: line over 80 characters
#70: FILE: hw/can/can_mioe3680_pci.c:46:
+#define MIOe3680_PCI_VENDOR_ID1     0x13fe    /* the PCI device and vendor IDs 
*/

total: 0 errors, 1 warnings, 340 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/7: QEMU CAN bus emulation documentation...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden