[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/12] configure: disable unaligned access warni
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 10/12] configure: disable unaligned access warning on x86 arch |
Date: |
Mon, 8 Jan 2018 19:53:06 +0200 |
On Mon, Jan 08, 2018 at 05:32:54PM +0000, Peter Maydell wrote:
> On 8 January 2018 at 17:29, Philippe Mathieu-Daudé <address@hidden> wrote:
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> > configure | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
>
> This doesn't seem like the right approach to me. We
> want this sort of thing to be a warning/error on x86,
> because that's the host that everybody actually uses
> to develop with. If they only show up on non-x86
> hosts then the result will be a lot more bounced
> pull requests because of only-non-x86 warnings.
>
> thanks
> -- PMM
And we can't be sure the compiler won't be doing something tricky by
assuming alignment in the future.
--
MST
- [Qemu-devel] [PATCH 07/12] slirp: remove unnecessary, (continued)
- [Qemu-devel] [PATCH 07/12] slirp: remove unnecessary, Philippe Mathieu-Daudé, 2018/01/08
- [Qemu-devel] [PATCH 08/12] slirp: removed unused code, Philippe Mathieu-Daudé, 2018/01/08
- [Qemu-devel] [PATCH 09/12] slirp: add in6_dhcp_multicast(), Philippe Mathieu-Daudé, 2018/01/08
- [Qemu-devel] [PATCH 10/12] configure: disable unaligned access warning on x86 arch, Philippe Mathieu-Daudé, 2018/01/08
- [Qemu-devel] [PATCH 11/12] configure: add HOST_SUPPORTS_UNALIGNED_ACCESS, Philippe Mathieu-Daudé, 2018/01/08
- [Qemu-devel] [RFC PATCH 12/12] slirp: use HOST_SUPPORTS_UNALIGNED_ACCESS, Philippe Mathieu-Daudé, 2018/01/08
- Re: [Qemu-devel] [PATCH 00/12] add HOST_SUPPORTS_UNALIGNED_ACCESS, reduce slirp warnings, no-reply, 2018/01/08