[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of
|
From: |
Hikaru Nishida |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe |
|
Date: |
Tue, 9 Jan 2018 09:38:04 +0900 |
Thank you for applying my patch.
> I had to resolve conflicts with the tracing patches and chose to keep
> the trace points from pci_irq_pulse() for pci_irq_assert(), but didn't
> add them to pci_irq_deassert(). Please check if this makes sense to you.
It makes sense for now.
I will send another patch shortly to improve some points of the
tracing functions.
Hikaru Nishida
2018-01-09 0:28 GMT+09:00 Kevin Wolf <address@hidden>:
> Am 18.12.2017 um 06:00 hat Hikaru Nishida geschrieben:
>> Pin-based interrupt of NVMe controller did not work properly
>> because using an obsolated function pci_irq_pulse().
>> To fix this, change to use pci_irq_assert() / pci_irq_deassert()
>> instead of pci_irq_pulse().
>>
>> Signed-off-by: Hikaru Nishida <address@hidden>
>
> Thanks, applied to the block branch.
>
> I had to resolve conflicts with the tracing patches and chose to keep
> the trace points from pci_irq_pulse() for pci_irq_assert(), but didn't
> add them to pci_irq_deassert(). Please check if this makes sense to you.
> Here is the commit after my conflict resolution:
>
> http://repo.or.cz/qemu/kevin.git/commitdiff/44c55a9159f2048a26c07e50dbc21c934917b82c
>
> Kevin