[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/7] net: struct MACAddr can use the QEMU_PACKED
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 1/7] net: struct MACAddr can use the QEMU_PACKED macro |
Date: |
Tue, 9 Jan 2018 08:26:09 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 01/08/2018 10:02 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/net/net.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/net.h b/include/net/net.h
> index 4afac1a9dd..70f5bb3419 100644
> --- a/include/net/net.h
> +++ b/include/net/net.h
> @@ -23,7 +23,7 @@
>
> struct MACAddr {
> uint8_t a[6];
> -};
> +} QEMU_PACKED;
I suppose the arm32 abi does pad structs to a multiple of 4. Does this
actually affect anything else?
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH 0/7] use QEMU_PACKED and QEMU_ALIGNED macros, Philippe Mathieu-Daudé, 2018/01/08
- [Qemu-devel] [PATCH 1/7] net: struct MACAddr can use the QEMU_PACKED macro, Philippe Mathieu-Daudé, 2018/01/08
- Re: [Qemu-devel] [PATCH 1/7] net: struct MACAddr can use the QEMU_PACKED macro,
Richard Henderson <=
- [Qemu-devel] [PATCH 2/7] net/eth: use the QEMU_PACKED macro, Philippe Mathieu-Daudé, 2018/01/08
- [Qemu-devel] [PATCH 4/7] net/rocker: move struct rocker_desc to C file, Philippe Mathieu-Daudé, 2018/01/08
- [Qemu-devel] [PATCH 5/7] net/eepro100: use QEMU_ALIGNED() macro, Philippe Mathieu-Daudé, 2018/01/08
- [Qemu-devel] [PATCH 3/7] net/rocker: use QEMU_PACKED and QEMU_ALIGNED() macros, Philippe Mathieu-Daudé, 2018/01/08
- [Qemu-devel] [RFC PATCH 6/7] net/eepro100: reduce alignment to DWORD (32bit), Philippe Mathieu-Daudé, 2018/01/08