[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration |
Date: |
Wed, 10 Jan 2018 11:49:18 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Juan Quintela (address@hidden) wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> tests/migration-test.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index d81f22118b..f469235d0b 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -440,13 +440,13 @@ static void test_migrate_start(QTestState **from,
> QTestState **to,
>
> if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
> init_bootfile_x86(bootpath);
> - cmd_src = g_strdup_printf("-machine accel=%s -m 150M"
> - " -name pcsource,debug-threads=on"
> + cmd_src = g_strdup_printf("-machine accel=%s -m 256M"
> + " -name source,debug-threads=on"
> " -serial file:%s/src_serial"
> " -drive file=%s,format=raw",
> accel, tmpfs, bootpath);
> - cmd_dst = g_strdup_printf("-machine accel=%s -m 150M"
> - " -name pcdest,debug-threads=on"
> + cmd_dst = g_strdup_printf("-machine accel=%s -m 256M"
> + " -name target,debug-threads=on"
> " -serial file:%s/dest_serial"
> " -drive file=%s,format=raw"
> " -incoming %s",
> @@ -459,12 +459,12 @@ static void test_migrate_start(QTestState **from,
> QTestState **to,
> }
> init_bootfile_ppc(bootpath);
> cmd_src = g_strdup_printf("-machine accel=%s -m 256M"
> - " -name pcsource,debug-threads=on"
> + " -name source,debug-threads=on"
> " -serial file:%s/src_serial"
> " -drive file=%s,if=pflash,format=raw",
> accel, tmpfs, bootpath);
> cmd_dst = g_strdup_printf("-machine accel=%s -m 256M"
> - " -name pcdest,debug-threads=on"
> + " -name target,debug-threads=on"
> " -serial file:%s/dest_serial"
> " -drive file=%s,if=pflash,format=raw"
> " -incoming %s",
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
(I'm OK with increasing the RAM size but we don't need to, some may find
it a bit wasteful in tests, but it's only 106M extra)
> --
> 2.14.3
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments, (continued)
[Qemu-devel] [PATCH v4 03/11] tests: Consolidate accelerators declaration, Juan Quintela, 2018/01/05
[Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration, Juan Quintela, 2018/01/05
Re: [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration,
Dr. David Alan Gilbert <=
[Qemu-devel] [PATCH v4 07/11] tests: Add basic migration precopy tcp test, Juan Quintela, 2018/01/05
[Qemu-devel] [PATCH v4 06/11] tests: Add migration precopy test, Juan Quintela, 2018/01/05
[Qemu-devel] [PATCH v4 05/11] tests: Add deprecated commands migration test, Juan Quintela, 2018/01/05
[Qemu-devel] [PATCH v4 08/11] tests: Add migration xbzrle test, Juan Quintela, 2018/01/05
[Qemu-devel] [PATCH v4 10/11] tests: Adjust sleeps for migration test, Juan Quintela, 2018/01/05
[Qemu-devel] [PATCH v4 09/11] tests: Create migrate-start-postcopy command, Juan Quintela, 2018/01/05