Re: [Qemu-devel] [PATCH] block/iscsi: fix initialization of iTask in iscsi_co_get_block_status

[Paolo Bonzini]

On 08/01/2018 16:27, Peter Lieven wrote:
> in case of unaligned requests or on a target that does not support
> block provisioning we leave iTask uninitialized and check iTask.task
> for NULL later.
> 
> Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8
> Cc: address@hidden
> Signed-off-by: Peter Lieven <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  block/iscsi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 5c0a9e5..6a1c537 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -658,6 +658,8 @@ static int64_t coroutine_fn 
> iscsi_co_get_block_status(BlockDriverState *bs,
>      uint64_t lba;
>      int64_t ret;
>  
> +    iscsi_co_init_iscsitask(iscsilun, &iTask);
> +
>      if (!is_sector_request_lun_aligned(sector_num, nb_sectors, iscsilun)) {
>          ret = -EINVAL;
>          goto out;
> @@ -675,7 +677,6 @@ static int64_t coroutine_fn 
> iscsi_co_get_block_status(BlockDriverState *bs,
>  
>      lba = sector_qemu2lun(sector_num, iscsilun);
>  
> -    iscsi_co_init_iscsitask(iscsilun, &iTask);
>      qemu_mutex_lock(&iscsilun->mutex);
>  retry:
>      if (iscsi_get_lba_status_task(iscsilun->iscsi, iscsilun->lun,
> 

Queued (removing Cc qemu-stable), thanks.

Paolo