[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 0/9] block: Add VFIO based driver for NVMe de
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v5 0/9] block: Add VFIO based driver for NVMe device |
Date: |
Fri, 12 Jan 2018 09:46:19 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, Jan 12, 2018 at 04:55:46PM +0800, Fam Zheng wrote:
> v5: Add Stefan's rev-bys.
> Add Paolo's sob line.
> Address Stefan's, Alex's and Eric's comments, including:
> - Add PCI Bar MMIO offset/size parameter to VFIO utility API. [Alex]
> - Fix various lock and memory leakings. [Stefan]
> - Improve documentation. [Stefan]
> - Add one missing "Since 2.12" in QAPI schema. [Eric]
> - Fix locking of BDRVNVMeState->inflight. [Stefan]
> - Add one missing endianness conversion for cmd.nsid. [Stefan]
> - Use bdrv_get_aio_context() instead of qemu_get_current_aio_context().
> - When init, issue "Set Features" command to enable/disable volatile write
> cache according to "flags & BDRV_O_NOCACHE".
I left comments on the main patch. The rest looks good.
Stefan
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v5 4/9] block: Introduce buf register API, (continued)
- [Qemu-devel] [PATCH v5 4/9] block: Introduce buf register API, Fam Zheng, 2018/01/12
- [Qemu-devel] [PATCH v5 3/9] block: Add VFIO based NVMe driver, Fam Zheng, 2018/01/12
- [Qemu-devel] [PATCH v5 5/9] block/nvme: Implement .bdrv_(un)register_buf, Fam Zheng, 2018/01/12
- [Qemu-devel] [PATCH v5 6/9] qemu-img: Map bench buffer, Fam Zheng, 2018/01/12
- [Qemu-devel] [PATCH v5 8/9] docs: Add section for NVMe VFIO driver, Fam Zheng, 2018/01/12
- [Qemu-devel] [PATCH v5 7/9] block: Move NVMe constants to a separate header, Fam Zheng, 2018/01/12
- [Qemu-devel] [PATCH v5 9/9] qapi: Add NVMe driver options to the schema, Fam Zheng, 2018/01/12
- Re: [Qemu-devel] [PATCH v5 0/9] block: Add VFIO based driver for NVMe device,
Stefan Hajnoczi <=