[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 12/14] ui: place a hard cap on VNC server output
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PULL 12/14] ui: place a hard cap on VNC server output buffer size |
Date: |
Fri, 12 Jan 2018 16:50:29 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, Jan 12, 2018 at 04:40:32PM +0000, Peter Maydell wrote:
> On 12 January 2018 at 12:58, Gerd Hoffmann <address@hidden> wrote:
> > From: "Daniel P. Berrange" <address@hidden>
>
> Hi Dan: just FYI:
>
> > The previous patches fix problems with throttling of forced framebuffer
> > updates
> > and audio data capture that would cause the QEMU output buffer size to grow
> > without bound. Those fixes are graceful in that once the client catches up
> > with
> > reading data from the server, everything continues operating normally.
>
> 12345678901234567890123456789012345678901234567890123456789012345678901234567890
> 1 2 3 4 5 6 7
> 8
>
> Your wrap settings on your editor for git commit messages seem to be a
> bit mis-set -- wrapping around 72 cols or so is recommended.
>
> I've applied the pullreq but noticed in passing that git log wraps
> a bit awkwardly on an 80-column xterm.
Thanks, I'll see about fixing that
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PULL 04/14] ui: remove redundant indentation in vnc_client_update, (continued)
- [Qemu-devel] [PULL 04/14] ui: remove redundant indentation in vnc_client_update, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 08/14] ui: correctly reset framebuffer update state after processing dirty regions, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 05/14] ui: avoid pointless VNC updates if framebuffer isn't dirty, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 07/14] ui: introduce enum to track VNC client framebuffer update request state, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 02/14] ui: remove 'sync' parameter from vnc_update_client, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 01/14] vnc: fix debug spelling, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 09/14] ui: refactor code for determining if an update should be sent to the client, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 13/14] ui: add trace events related to VNC client throttling, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 12/14] ui: place a hard cap on VNC server output buffer size, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 06/14] ui: track how much decoded data we consumed when doing SASL encoding, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 14/14] ui: mix misleading comments & return types of VNC I/O helper methods, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 10/14] ui: fix VNC client throttling when audio capture is active, Gerd Hoffmann, 2018/01/12
- Re: [Qemu-devel] [PULL 10/14] ui: fix VNC client throttling when audio capture is active, Peter Maydell, 2018/01/18
- Re: [Qemu-devel] [PULL 10/14] ui: fix VNC client throttling when audio capture is active, Daniel P. Berrange, 2018/01/18
- Re: [Qemu-devel] [PULL 10/14] ui: fix VNC client throttling when audio capture is active, Paolo Bonzini, 2018/01/18
- Re: [Qemu-devel] [PULL 10/14] ui: fix VNC client throttling when audio capture is active, Daniel P. Berrange, 2018/01/18
- Re: [Qemu-devel] [PULL 10/14] ui: fix VNC client throttling when audio capture is active, Paolo Bonzini, 2018/01/18
- Re: [Qemu-devel] [PULL 10/14] ui: fix VNC client throttling when audio capture is active, Peter Maydell, 2018/01/18
- Re: [Qemu-devel] [PULL 10/14] ui: fix VNC client throttling when audio capture is active, Paolo Bonzini, 2018/01/18