Re: [Qemu-devel] [PATCH 5/8] ipmi: disable IRQ and ATN on an external disconnect

[Marc-André Lureau]

Hi

On Thu, Dec 7, 2017 at 10:30 PM,  <address@hidden> wrote:
> From: Corey Minyard <address@hidden>
>
> Otherwise there's no way to clear them without an external command,
> and it could lock the OS in the VM if they were stuck.
>
> Signed-off-by: Corey Minyard <address@hidden>

I don't know if anyone knows the specifics better than you. Why aren't
you the maintainer of hw/ipmi? (in MAINTAINERS)

> ---
>  hw/ipmi/ipmi_bmc_extern.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
> index abab3bb..58ade79 100644
> --- a/hw/ipmi/ipmi_bmc_extern.c
> +++ b/hw/ipmi/ipmi_bmc_extern.c
> @@ -424,6 +424,11 @@ static void chr_event(void *opaque, int event)
>              return;
>          }
>          ibe->connected = false;
> +        /*
> +         * Don't hang the OS trying to handle the ATN bit, other end will
> +         * resend on a reconnect.
> +         */
> +        k->set_atn(s, 0, 0);
>          if (ibe->waiting_rsp) {
>              ibe->waiting_rsp = false;
>              ibe->inbuf[1] = ibe->outbuf[1] | 0x04;
> --
> 2.7.4
>
>



-- 
Marc-André Lureau