[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] xilinx_spips: Correct usage of an uninitialized loc
From: |
Francisco Iglesias |
Subject: |
[Qemu-devel] [PATCH] xilinx_spips: Correct usage of an uninitialized local variable |
Date: |
Sun, 14 Jan 2018 23:55:43 +0100 |
Coverity found that the variable tx_rx in the function
xilinx_spips_flush_txfifo was being used uninitialized (CID 1383841). This
patch corrects this by always initializing tx_rx to zeros.
Signed-off-by: Francisco Iglesias <address@hidden>
---
hw/ssi/xilinx_spips.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
index d8187fa..77e1bbe 100644
--- a/hw/ssi/xilinx_spips.c
+++ b/hw/ssi/xilinx_spips.c
@@ -210,6 +210,8 @@
#define SNOOP_NONE 0xEE
#define SNOOP_STRIPING 0
+#define MAX_NUM_EFFECTIVE_BUSSES 2
+
static inline int num_effective_busses(XilinxSPIPS *s)
{
return (s->regs[R_LQSPI_CFG] & LQSPI_CFG_SEP_BUS &&
@@ -573,7 +575,7 @@ static void xilinx_spips_flush_txfifo(XilinxSPIPS *s)
for (;;) {
int i;
uint8_t tx = 0;
- uint8_t tx_rx[num_effective_busses(s)];
+ uint8_t tx_rx[MAX_NUM_EFFECTIVE_BUSSES] = { 0 };
uint8_t dummy_cycles = 0;
uint8_t addr_length;
--
2.9.3
- [Qemu-devel] [PATCH] xilinx_spips: Correct usage of an uninitialized local variable,
Francisco Iglesias <=