Re: [Qemu-devel] [RFC PATCH 1/3] qdev: rename typedef qdev_resetfn() -> DeviceReset()

[Laurent Vivier]

Le 14/01/2018 à 03:04, Philippe Mathieu-Daudé a écrit :
> following the DeviceRealize and DeviceUnrealize typedefs,
> this unify a bit the new QOM API.
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  include/hw/qdev-core.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
> index 0a71bf83f0..83db53b3f5 100644
> --- a/include/hw/qdev-core.h
> +++ b/include/hw/qdev-core.h
> @@ -32,9 +32,9 @@ typedef enum DeviceCategory {
>  
>  typedef int (*qdev_initfn)(DeviceState *dev);
>  typedef int (*qdev_event)(DeviceState *dev);
> -typedef void (*qdev_resetfn)(DeviceState *dev);
>  typedef void (*DeviceRealize)(DeviceState *dev, Error **errp);
>  typedef void (*DeviceUnrealize)(DeviceState *dev, Error **errp);
> +typedef void (*DeviceReset)(DeviceState *dev);
>  typedef void (*BusRealize)(BusState *bus, Error **errp);
>  typedef void (*BusUnrealize)(BusState *bus, Error **errp);
>  
> @@ -117,7 +117,7 @@ typedef struct DeviceClass {
>      bool hotpluggable;
>  
>      /* callbacks */
> -    void (*reset)(DeviceState *dev);
> +    DeviceReset reset;
>      DeviceRealize realize;
>      DeviceUnrealize unrealize;
>  
> 
Reviewed-by: Laurent Vivier <address@hidden>