[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/7] docker: do not display deprecated images in
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 2/7] docker: do not display deprecated images in 'make docker' help |
Date: |
Wed, 17 Jan 2018 10:38:34 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/16/2018 11:10 PM, Fam Zheng wrote:
> On 01/12/2018 08:49 PM, Philippe Mathieu-Daudé wrote:
>> the 'debian' base image is deprecated since 3e11974988d8
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> tests/docker/Makefile.include | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/docker/Makefile.include
>> b/tests/docker/Makefile.include
>> index ef95703cef..f0cd26c2b6 100644
>> --- a/tests/docker/Makefile.include
>> +++ b/tests/docker/Makefile.include
>> @@ -4,7 +4,8 @@
>> DOCKER_SUFFIX := .docker
>> DOCKER_FILES_DIR := $(SRC_PATH)/tests/docker/dockerfiles
>> -DOCKER_IMAGES := $(sort $(notdir $(basename $(wildcard
>> $(DOCKER_FILES_DIR)/*.docker))))
>> +DOCKER_DEPRECATED_IMAGES := debian
>> +DOCKER_IMAGES := $(filter-out $(DOCKER_DEPRECATED_IMAGES),$(sort
>> $(notdir $(basename $(wildcard $(DOCKER_FILES_DIR)/*.docker)))))
>> DOCKER_TARGETS := $(patsubst %,docker-image-%,$(DOCKER_IMAGES))
>> # Use a global constant ccache directory to speed up repetitive builds
>> DOCKER_CCACHE_DIR := $$HOME/.cache/qemu-docker-ccache
>
> While we are at it, could you please just spell out this list
> explicitly, consistent to how we build obj-y variables?
What I like with the current approach is one can have
more/different/specific images to run the tests, without having to
pollute upstream with plenty of more docker images (you just drop your
Dockerfile in DOCKER_FILES_DIR and 'make docker-test' run them all).
- [Qemu-devel] [PATCH 0/7] docker: update Ubuntu and Fedora images, deprecate old ones, Philippe Mathieu-Daudé, 2018/01/12
- [Qemu-devel] [PATCH 1/7] docker: sort images list displayed by 'make docker', Philippe Mathieu-Daudé, 2018/01/12
- [Qemu-devel] [PATCH 2/7] docker: do not display deprecated images in 'make docker' help, Philippe Mathieu-Daudé, 2018/01/12
- [Qemu-devel] [PATCH 3/7] docker: add the Ubuntu Trusty base image, Philippe Mathieu-Daudé, 2018/01/12
- [Qemu-devel] [PATCH 4/7] docker: do not use Trusty APT source in Xenial, Philippe Mathieu-Daudé, 2018/01/12
- [Qemu-devel] [PATCH 5/7] docker: warn users to use ubuntu16.04 for the LTS Xenial image, Philippe Mathieu-Daudé, 2018/01/12
- [Qemu-devel] [PATCH 6/7] docker: add the Fedora 27 base image, Philippe Mathieu-Daudé, 2018/01/12
- [Qemu-devel] [PATCH 7/7] docker: warn users to use newer fedora25/fedora27 base image, Philippe Mathieu-Daudé, 2018/01/12
- Re: [Qemu-devel] [PATCH 0/7] docker: update Ubuntu and Fedora images, deprecate old ones, no-reply, 2018/01/12