[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ppc/pnv: fix PnvChip redefinition in <hw/ppc/pn
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH] ppc/pnv: fix PnvChip redefinition in <hw/ppc/pnv_xscom.h> |
|
Date: |
Fri, 19 Jan 2018 09:30:48 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 19.01.2018 09:15, Cédric Le Goater wrote:
> This redefinition generates warnings on some clang compilers and older
> gcc4.4.
>
> ...include/hw/ppc/pnv_xscom.h:24:24: warning: redefinition of typedef
> 'PnvChip' is a C11
> feature [-Wtypedef-redefinition]
> typedef struct PnvChip PnvChip;
> ^
> ...include/hw/ppc/pnv.h:65:3: note: previous definition is here
> } PnvChip;
> ^
> 1 warning generated.
> CC ppc64-softmmu/hw/ppc/pnv_xscom.o
>
> Signed-off-by: Cédric Le Goater <address@hidden>
> ---
> include/hw/ppc/pnv_xscom.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h
> index fb1bd5df095a..255b26a5aaf6 100644
> --- a/include/hw/ppc/pnv_xscom.h
> +++ b/include/hw/ppc/pnv_xscom.h
> @@ -21,8 +21,6 @@
>
> #include "qom/object.h"
>
> -typedef struct PnvChip PnvChip;
> -
> typedef struct PnvXScomInterface {
> Object parent;
> } PnvXScomInterface;
>
Reviewed-by: Thomas Huth <address@hidden>