[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v4 12/23] cpus: push BQL lock to qemu_*_wait
From: |
Pavel Dovgalyuk |
Subject: |
Re: [Qemu-devel] [RFC PATCH v4 12/23] cpus: push BQL lock to qemu_*_wait_io_event |
Date: |
Fri, 19 Jan 2018 14:52:37 +0300 |
> From: Paolo Bonzini [mailto:address@hidden
> On 19/01/2018 09:44, Pavel Dovgalyuk wrote:
> > static void qemu_wait_io_event(CPUState *cpu)
> > {
> > + qemu_mutex_lock_iothread();
> > +
> > while (cpu_thread_is_idle(cpu)) {
> > qemu_cond_wait(cpu->halt_cond, &qemu_global_mutex);
> > }
>
> This function locks the iothread and never unlocks it. Please test your
> patches better.
Yes, there was kind of mess. Lock was inside the function and unlock outside,
that's why it worked for me.
Pavel Dovgalyuk
- [Qemu-devel] [RFC PATCH v4 04/23] replay: disable default snapshot for record/replay, (continued)
- [Qemu-devel] [RFC PATCH v4 04/23] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 05/23] replay: fix processing async events, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 06/23] replay: fixed replay_enable_events, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 07/23] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 08/23] replay: added replay log format description, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 09/23] replay: make safe vmstop at record/replay, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 10/23] replay: save prior value of the host clock, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 11/23] target/arm/arm-powertctl: drop BQL assertions, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 12/23] cpus: push BQL lock to qemu_*_wait_io_event, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 14/23] replay/replay.c: bump REPLAY_VERSION again, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads, Pavel Dovgalyuk, 2018/01/19
- Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads, Paolo Bonzini, 2018/01/19
- Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads, Pavel Dovgalyuk, 2018/01/19
- Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads, Paolo Bonzini, 2018/01/19
- Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads, Pavel Dovgalyuk, 2018/01/19
- Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads, Paolo Bonzini, 2018/01/19
- Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads, Pavel Dovgalyuk, 2018/01/19
- Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads, Pavel Dovgalyuk, 2018/01/19
- Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads, Paolo Bonzini, 2018/01/19