qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v4 12/23] cpus: push BQL lock to qemu_*_wait


From: Pavel Dovgalyuk
Subject: Re: [Qemu-devel] [RFC PATCH v4 12/23] cpus: push BQL lock to qemu_*_wait_io_event
Date: Fri, 19 Jan 2018 14:52:37 +0300

> From: Paolo Bonzini [mailto:address@hidden
> On 19/01/2018 09:44, Pavel Dovgalyuk wrote:
> >  static void qemu_wait_io_event(CPUState *cpu)
> >  {
> > +    qemu_mutex_lock_iothread();
> > +
> >      while (cpu_thread_is_idle(cpu)) {
> >          qemu_cond_wait(cpu->halt_cond, &qemu_global_mutex);
> >      }
> 
> This function locks the iothread and never unlocks it.  Please test your
> patches better.

Yes, there was kind of mess. Lock was inside the function and unlock outside,
that's why it worked for me.

Pavel Dovgalyuk




reply via email to

[Prev in Thread] Current Thread [Next in Thread]