Re: [Qemu-devel] [PATCH v3 0/4] linux-user: select CPU type according ELF header values

[Igor Mammedov]

On Fri, 19 Jan 2018 14:56:53 +0100
Laurent Vivier <address@hidden> wrote:

> Le 17/01/2018 à 16:49, Igor Mammedov a écrit :
> > On Tue, 16 Jan 2018 23:22:08 +0100
> > Laurent Vivier <address@hidden> wrote:
> > 
> >> This idea has been suggested to me before by Philippe
> >> Mathieu-Daudé, and recently YunQiang Su has proposed a
> >> patch to manage the MIPS r6 case.
> >>
> >> Based on this, this series tries to clean-up the original
> >> patch, and introduces the use for m68k architecture and
> >> port the patch from YunQiang Su.
> >>
> >> v3: fix code indent problem reported by patchew
> >>     remove useless "!= 0"
> >>     check for EF_M68K_M68000
> >>     add EF_M68K_* flags in elf.h
> >>     set 680x0 default CPU to m68040
> >>     change "#if ... #endif" structure for ppc
> >> v2: move cpu_model selection to linux-user/*/target_elf.h
> >>     provide eflags to cpu_get_model() instead of fd
> >>     (and modify other patches accordingly)
> > Sorry for not noticing it earlier, but could you please
> > fix series to use cpu type names instead of cpu_model?
> 
> As your series is not ready for inclusion, perhaps we can take my series
> first?
> 
> I'll happily help you to adapt your series on top of this one if you need.
It wasn't about whose series goes first (I don't really care as I can rebase),

suggestion was about using cpu types instead of cpu models
which you are adding/moving into linux-user/*/target_elf.h

Otherwise we would need immediately to have a patch on top that
replaces them in linux-user/*/target_elf.h with cpu types.

So I'd rather amend this series so that it would use cpu types
from the start instead of doing refactoring on top which just
doubles amount of touched lines.



> Thanks,
> Laurent
>