[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 11/16] target/arm: Add SVE to migration state
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 11/16] target/arm: Add SVE to migration state |
Date: |
Mon, 22 Jan 2018 14:16:31 +0000 |
On 19 January 2018 at 04:54, Richard Henderson
<address@hidden> wrote:
> Save the high parts of the Zregs and all of the Pregs.
> The ZCR_ELx registers are migrated via the CP mechanism.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/arm/machine.c | 53
> ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 53 insertions(+)
>
> diff --git a/target/arm/machine.c b/target/arm/machine.c
> index cb0e1c92bb..2c8b43062f 100644
> --- a/target/arm/machine.c
> +++ b/target/arm/machine.c
> @@ -122,6 +122,56 @@ static const VMStateDescription vmstate_iwmmxt = {
> }
> };
>
> +#ifdef TARGET_AARCH64
> +/* The expression ARM_MAX_VQ - 2 is 0 for pure AArch32 build,
> + * and ARMPredicateReg is actively empty. This triggers errors
> + * in the expansion of the VMSTATE macros.
> + */
> +
> +static bool sve_needed(void *opaque)
> +{
> + ARMCPU *cpu = opaque;
> + CPUARMState *env = &cpu->env;
> +
> + return arm_feature(env, ARM_FEATURE_SVE);
> +}
> +
> +/* The first two words of each Zreg is stored in VFP state. */
> +static const VMStateDescription vmstate_zreg_hi_reg = {
> + .name = "cpu/sve/zreg_hi",
> + .version_id = 1,
> + .minimum_version_id = 1,
> + .fields = (VMStateField[]) {
> + VMSTATE_UINT64_SUB_ARRAY(d, ARMVectorReg, 2, ARM_MAX_VQ - 2),
> + VMSTATE_END_OF_LIST()
> + }
> +};
> +
> +static const VMStateDescription vmstate_preg_reg = {
> + .name = "cpu/sve/preg",
> + .version_id = 1,
> + .minimum_version_id = 1,
> + .fields = (VMStateField[]) {
> + VMSTATE_UINT64_ARRAY(p, ARMPredicateReg, 2 * ARM_MAX_VQ / 8),
> + VMSTATE_END_OF_LIST()
> + }
> +};
> +
> +static const VMStateDescription vmstate_sve = {
> + .name = "cpu/sve",
> + .version_id = 1,
> + .minimum_version_id = 1,
> + .needed = sve_needed,
> + .fields = (VMStateField[]) {
> + VMSTATE_STRUCT_ARRAY(env.vfp.zregs, ARMCPU, 32, 0,
> + vmstate_zreg_hi_reg, ARMVectorReg),
> + VMSTATE_STRUCT_ARRAY(env.vfp.pregs, ARMCPU, 17, 0,
> + vmstate_preg_reg, ARMPredicateReg),
Is it the QEMU_ALIGNED attribute that means we need to do the pregs
via a STRUCT_ARRAY rather than being able to use a UINT64_2DARRAY ?
> + VMSTATE_END_OF_LIST()
> + }
> +};
> +#endif /* AARCH64 */
thanks
-- PMM
- [Qemu-devel] [PATCH v2 08/16] target/arm: Expand vector registers for SVE, (continued)
- [Qemu-devel] [PATCH v2 08/16] target/arm: Expand vector registers for SVE, Richard Henderson, 2018/01/18
- [Qemu-devel] [PATCH v2 10/16] target/arm: Add ARM_FEATURE_SVE, Richard Henderson, 2018/01/18
- [Qemu-devel] [PATCH v2 09/16] target/arm: Add predicate registers for SVE, Richard Henderson, 2018/01/18
- [Qemu-devel] [PATCH v2 11/16] target/arm: Add SVE to migration state, Richard Henderson, 2018/01/18
- [Qemu-devel] [PATCH v2 06/16] target/arm: Add aa{32, 64}_vfp_{dreg, qreg} helpers, Richard Henderson, 2018/01/18
- [Qemu-devel] [PATCH v2 12/16] target/arm: Add ZCR_ELx, Richard Henderson, 2018/01/18
- [Qemu-devel] [PATCH v2 15/16] target/arm: Simplify fp_exception_el for user-only, Richard Henderson, 2018/01/18
- [Qemu-devel] [PATCH v2 14/16] target/arm: Hoist store to flags output in cpu_get_tb_cpu_state, Richard Henderson, 2018/01/18