[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disa
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable |
Date: |
Mon, 22 Jan 2018 14:56:46 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/22/2018 02:51 PM, Eric Blake wrote:
> On 01/22/2018 03:09 AM, Vladimir Sementsov-Ogievskiy wrote:
>
>>>>
>>> I have to admit exposing this interface still makes me nervous, but :)
>>>
>>> Mechanically correct, and with suggesting phrasing changes:
>>>
>>> Reviewed-by: John Snow <address@hidden>
>
> Should we go with an x- prefix for now, and let things settle for a
> release before promoting it to fully supported, just in case we find
> something that justifies your nervousness in accepting the interface?
>
I proposed as much in a reply to the cover letter; I'm willing to take
patch one now for the sake of migration; the rest of this series I want
a test suite that helps document the anticipated use case, or otherwise
an x- prefix for the command names.
- Re: [Qemu-devel] [PATCH v2 4/6] qmp: transaction support for block-dirty-bitmap-enable/disable, (continued)
[Qemu-devel] [PATCH v2 6/6] qapi: add disabled parameter to block-dirty-bitmap-add, Vladimir Sementsov-Ogievskiy, 2018/01/16
[Qemu-devel] [PATCH v2 5/6] qapi: add block-dirty-bitmap-merge, Vladimir Sementsov-Ogievskiy, 2018/01/16
[Qemu-devel] [PATCH v2 2/6] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap, Vladimir Sementsov-Ogievskiy, 2018/01/16
[Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable, Vladimir Sementsov-Ogievskiy, 2018/01/16
[Qemu-devel] [PATCH v2 1/6] block: maintain persistent disabled bitmaps, Vladimir Sementsov-Ogievskiy, 2018/01/16
Re: [Qemu-devel] [PATCH v2 0/6] qmp dirty bitmap API, John Snow, 2018/01/19