[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v9 12/16] sdhci: Fix 64-bit ADMA2
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] [PATCH v9 12/16] sdhci: Fix 64-bit ADMA2 |
Date: |
Mon, 22 Jan 2018 23:08:16 -0300 |
From: Sai Pavan Boddu <address@hidden>
The 64-bit ADMA address is not converted to the cpu endianes correctly.
This patch fixes the issue and uses a valid mask for the attribute data.
Signed-off-by: Sai Pavan Boddu <address@hidden>
[AF: Re-write commit message]
Reviewed-by: Alistair Francis <address@hidden>
---
hw/sd/sdhci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 9f9d6835c0..a6bba1939f 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -667,8 +667,8 @@ static void get_adma_description(SDHCIState *s, ADMADescr
*dscr)
dscr->length = le16_to_cpu(dscr->length);
dma_memory_read(s->dma_as, entry_addr + 4,
(uint8_t *)(&dscr->addr), 8);
- dscr->attr = le64_to_cpu(dscr->attr);
- dscr->attr &= 0xfffffff8;
+ dscr->addr = le64_to_cpu(dscr->addr);
+ dscr->attr &= (uint8_t) ~0xC0;
dscr->incr = 12;
break;
}
--
2.15.1
- [Qemu-devel] [PATCH v9 04/16] sdhci: add a check_capab_baseclock() qtest, (continued)
- [Qemu-devel] [PATCH v9 04/16] sdhci: add a check_capab_baseclock() qtest, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v9 05/16] sdhci: add a check_capab_sdma() qtest, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v9 06/16] sdhci: add qtest to check the SD Spec version, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v9 07/16] sdhci: add a 'spec_version property' (default to v2), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v9 08/16] sdhci: use a numeric value for the default CAPAB register, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v9 09/16] sdhci: simplify sdhci_get_fifolen(), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v9 10/16] sdhci: check the Spec v1 capabilities correctness, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v9 12/16] sdhci: Fix 64-bit ADMA2,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v9 13/16] sdhci: check Spec v2 capabilities (DMA and 64-bit bus), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v9 14/16] hw/arm/exynos4210: access the 64-bit capareg with qdev_prop_set_uint64(), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v9 15/16] hw/arm/exynos4210: add a comment about a very similar SDHCI (Spec. v2), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v9 16/16] hw/arm/xilinx_zynq: fix the capabilities register to match the datasheet, Philippe Mathieu-Daudé, 2018/01/22
- Re: [Qemu-devel] [PATCH v9 00/16] SDHCI: clean v1/v2 Specs (part 2), Philippe Mathieu-Daudé, 2018/01/31