[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image |
Date: |
Tue, 30 Jan 2018 22:12:43 +0800 |
On Tue, Jan 30, 2018 at 9:48 PM, Eric Blake <address@hidden> wrote:
> On 01/30/2018 12:25 AM, Fam Zheng wrote:
>> This reverts commit 76bf133c4 which updated the reference output, and
>> fixed the reference image, because the code path we want to exercise is
>> actually the invalid image size.
>>
>> The descriptor block in the image, which includes the CID to verify, has been
>> invalid since the reference image was added. Since commit 9877860e7bd we
>> report
>> this error earlier than the "file too large", so 059.out mismatches.
>>
>> The binary change is generated along the operations of:
>>
>> $ bunzip2 afl9.vmdk.bz2
>> $ qemu-img create -f vmdk fix.vmdk 1G
>> $ dd if=afl9.vmdk.bz2 of=fix.vmdk bs=512 count=1 conv=notrunc
>
> Is the .bz2 suffix spurious here?
Hmm, yes. I have no idea why it is here. :-/
Fam
>
>> $ mv fix.vmdk afl9.vmdk
>> $ bzip2 afl9.vmdk
>>
>> Signed-off-by: Fam Zheng <address@hidden>
>>
>> ---
>>
>
> Reviewed-by: Eric Blake <address@hidden>
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
>