[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/7] qdev: remove DeviceClass::init/exit()
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/7] qdev: remove DeviceClass::init/exit() |
Date: |
Wed, 31 Jan 2018 14:42:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> since v1:
> - fix format string on 32-bit host (patchew)
> - do not add smbus_eeprom_reset() (Eduardo)
> - directly use DeviceClass::realize (Eduardo)
> - squashed 2 patches (Eduardo)
>
> Hi,
>
> This series finalize the qdev QOMification.
Awesome!
It's been almost nine years since qdev, and more than 7 since QOM.
Sadly, I don't have the time to review this closely right now.
> We first convert the I2CSlave/SMBusDevice,
> then the usb-ccid and virtio-ccw,
> and finally the SysBusDevice.
>
> At the end we get one less TODO :)
>
> /* TODO remove, once users are converted to unrealize */
>
> There is still one standing in SysBusDeviceClass::init().
Another one in ssi_sd_realize(), I think. I didn't really look for
more.
- [Qemu-devel] [PATCH v2 0/7] qdev: remove DeviceClass::init/exit(), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v2 1/7] hw/i2c/smbus: use DeviceClass::realize instead of SMBusDeviceClass::init, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v2 2/7] hw/i2c: use DeviceClass::realize instead of I2CSlaveClass::init, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v2 5/7] qdev: simplify the SysBusDeviceClass::init path, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v2 3/7] usb-ccid: convert CCIDCardClass::init -> realize, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v2 4/7] virtio-ccw: convert VirtIOCCWDeviceClass::exit -> unrealize, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v2 7/7] qdev: rename typedef qdev_resetfn() -> DeviceReset(), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v2 6/7] qdev: remove DeviceClass::exit, Philippe Mathieu-Daudé, 2018/01/22
- Re: [Qemu-devel] [PATCH v2 0/7] qdev: remove DeviceClass::init/exit(),
Markus Armbruster <=