Re: [Qemu-devel] [PULL 2/8] ui: convert the SDL2 frontend to keycodemapdb

[Daniel P . Berrangé]

On Thu, Feb 01, 2018 at 12:28:02PM -0500, Paolo Bonzini wrote:
> On 25/01/2018 09:32, Gerd Hoffmann wrote:
> > --- a/include/ui/input.h
> > +++ b/include/ui/input.h
> > @@ -80,4 +80,7 @@ extern const guint16 qemu_input_map_qnum_to_qcode[];
> >  extern const guint qemu_input_map_qcode_to_linux_len;
> >  extern const guint16 qemu_input_map_qcode_to_linux[];
> 
> Is there any reason to use the length variables rather than just
> ARRAY_SIZE()?  Coverity isn't able to see through the initializer and
> incorrectly complains that

ARRAY_SIZE can only be used if you can see the array variable
initialization, but this is the header file so all we have is
the extern declaration and thus the array size is unknown from
the places that need to use the _len variable.

We do in fact initalize the _len variable based on the ARRAY_SIZE,
but that's in the .c files.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|