Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 02/02/2018 07:03 AM, Markus Armbruster wrote:
>> Error messages print absolute filenames of included files even gave a
>
> s/even gave/even when given/

I meant to write "even if the user gave".  Is that okay?

>> relative one on the command line:
>> 
>>      PYTHONPATH=scripts python -B tests/qapi-schema/test-qapi.py 
>> tests/qapi-schema/include-cycle.json
>>     In file included from tests/qapi-schema/include-cycle.json:1:
>>     In file included from 
>> /work/armbru/qemu/tests/qapi-schema/include-cycle-b.json:1:
>>     /work/armbru/qemu/tests/qapi-schema/include-cycle-c.json:1: Inclusion 
>> loop for include-cycle.json
>> 
>> Improve this to
>> 
>>     In file included from tests/qapi-schema/include-cycle.json:1:
>>     In file included from tests/qapi-schema/include-cycle-b.json:1:
>>     tests/qapi-schema/include-cycle-c.json:1: Inclusion loop for 
>> include-cycle.json
>
> Nice, and makes developing new qapi tests a little less painful since
> it's less modification to qapi-schema/*.err additions.

Probably not, as our make rule strips off $(SRC_PATH):

        @perl -p -e 's|\Q$(SRC_PATH)\E/||g' $*.test.err | diff -q 
$(SRC_PATH)/$*.err -

I've kept that, because it might also occur in stack backtraces.  I
think.

>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  scripts/qapi/common.py                | 12 ++++++------
>>  tests/qapi-schema/include-no-file.err |  2 +-
>>  2 files changed, 7 insertions(+), 7 deletions(-)
>> 
>
> Reviewed-by: Eric Blake <address@hidden>

Thanks!