[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 12/34] hyperv: add synic event flag signalin
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH 12/34] hyperv: add synic event flag signaling |
|
Date: |
Wed, 7 Feb 2018 11:58:58 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 06/02/2018 21:30, Roman Kagan wrote:
> +/*
> + * Set given event flag for a given sint on a given vcpu, and signal the
> sint.
> + */
> +int hyperv_set_evt_flag(HvSintRoute *sint_route, unsigned evtno)
Any reason (e.g. something from the spec) not to spell "event" and
"eventno" in full?
Thanks,
Paolo
> +{
> + int ret;
> + SynICState *synic = sint_route->synic;
> + unsigned long *flags, set_mask;
> + unsigned set_idx;
> +
> + if (evtno > HV_EVENT_FLAGS_COUNT) {
> + return -EINVAL;
> + }
> + if (!synic->enabled || !synic->evt_page_addr) {
[Qemu-devel] [RFC PATCH 13/34] hyperv: process SIGNAL_EVENT hypercall, Roman Kagan, 2018/02/06
[Qemu-devel] [RFC PATCH 14/34] hyperv: process POST_MESSAGE hypercall, Roman Kagan, 2018/02/06
[Qemu-devel] [RFC PATCH 16/34] hyperv: update copyright notices, Roman Kagan, 2018/02/06
[Qemu-devel] [RFC PATCH 15/34] hyperv_testdev: add SynIC message and event testmodes, Roman Kagan, 2018/02/06
[Qemu-devel] [RFC PATCH 17/34] [not to commit] import HYPERV_EVENTFD stuff from kernel, Roman Kagan, 2018/02/06
[Qemu-devel] [RFC PATCH 18/34] hyperv: add support for KVM_HYPERV_EVENTFD, Roman Kagan, 2018/02/06